Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lerna version maintains package-lock #235

Merged
merged 1 commit into from Nov 20, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Nov 14, 2019

resolves #234

Lerna version 3.18.2 will version package-lock.json files.
This means that if they are in .gitingnore the version command will fail.
Better visibility into versions should help debugging.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

resolves aws#234

Lerna version 3.18.2 will version package-lock.json files.
This means that if they are in .gitingnore the version command will fail.
Better visibility into versions should help debugging.
@seebees seebees requested review from agray256 and a team November 14, 2019 18:53
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seebees seebees merged commit c901318 into aws:master Nov 20, 2019
@seebees seebees deleted the add_package-lock branch November 20, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add package-lock.json to source control
2 participants