Add phase-type of QUEUED as constant (#234)

* Add phase-type of QUEUED as constant * Add to the test data also * fix assertions
aws · Oct 11, 2019 · 62a881e · 62a881e
1 parent 81cc163
commit 62a881e
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 1 deletion.
diff --git a/events/codebuild.go b/events/codebuild.go
@@ -27,6 +27,7 @@ type CodeBuildPhaseType string
 
 const (
 	CodeBuildPhaseTypeSubmitted       CodeBuildPhaseType = "SUBMITTED"
+	CodeBuildPhaseTypeQueued                             = "QUEUED"
 	CodeBuildPhaseTypeProvisioning                       = "PROVISIONING"
 	CodeBuildPhaseTypeDownloadSource                     = "DOWNLOAD_SOURCE"
 	CodeBuildPhaseTypeInstall                            = "INSTALL"

diff --git a/events/codebuild_test.go b/events/codebuild_test.go
@@ -2,10 +2,11 @@ package events
 
 import (
 	"encoding/json"
-	"github.com/stretchr/testify/require"
 	"io/ioutil"
 	"testing"
 	"time"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestUnmarshalCodeBuildEvent(t *testing.T) {
@@ -71,6 +72,14 @@ func TestUnmarshalCodeBuildEvent(t *testing.T) {
 								PhaseType:    CodeBuildPhaseTypeSubmitted,
 								PhaseStatus:  CodeBuildPhaseStatusSucceeded,
 							},
+							{
+								PhaseContext: []interface{}{},
+								StartTime:    CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)),
+								EndTime:      CodeBuildTime(time.Date(2019, 9, 13, 4, 12, 29, 0, time.UTC)),
+								Duration:     DurationSeconds(0),
+								PhaseType:    CodeBuildPhaseTypeQueued,
+								PhaseStatus:  CodeBuildPhaseStatusSucceeded,
+							},
 							{
 								PhaseContext: []interface{}{},
 								StartTime:    CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)),
@@ -200,6 +209,14 @@ func TestUnmarshalCodeBuildEvent(t *testing.T) {
 								PhaseType:    CodeBuildPhaseTypeSubmitted,
 								PhaseStatus:  CodeBuildPhaseStatusSucceeded,
 							},
+							{
+								PhaseContext: []interface{}{},
+								StartTime:    CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)),
+								EndTime:      CodeBuildTime(time.Date(2019, 9, 13, 4, 12, 29, 0, time.UTC)),
+								Duration:     DurationSeconds(0),
+								PhaseType:    CodeBuildPhaseTypeQueued,
+								PhaseStatus:  CodeBuildPhaseStatusSucceeded,
+							},
 							{
 								PhaseContext: []interface{}{},
 								StartTime:    CodeBuildTime(time.Date(2017, 9, 1, 16, 12, 29, 0, time.UTC)),

diff --git a/events/testdata/codebuild-phase-change.json b/events/testdata/codebuild-phase-change.json
@@ -49,6 +49,14 @@
                     "phase-type": "SUBMITTED",
                     "phase-status": "SUCCEEDED"
                 },
+                {
+                   "phase-context": [],
+                   "start-time": "Sep 1, 2017 4:12:29 PM",
+                   "end-time": "Sep 13, 2019 4:12:29 AM",
+                   "duration-in-seconds": 0.0,
+                   "phase-type": "QUEUED",
+                   "phase-status": "SUCCEEDED"
+                },
                 {
                     "phase-context": [],
                     "start-time": "Sep 1, 2017 4:12:29 PM",

diff --git a/events/testdata/codebuild-state-change.json b/events/testdata/codebuild-state-change.json
@@ -54,6 +54,14 @@
                     "phase-type": "SUBMITTED",
                     "phase-status": "SUCCEEDED"
                 },
+                {
+                   "phase-context": [],
+                   "start-time": "Sep 1, 2017 4:12:29 PM",
+                   "end-time": "Sep 13, 2019 4:12:29 AM",
+                   "duration-in-seconds": 0.0,
+                   "phase-type": "QUEUED",
+                   "phase-status": "SUCCEEDED"
+                },
                 {
                     "phase-context": [],
                     "start-time": "Sep 1, 2017 4:12:29 PM",