Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dialog action from lex event #240

Merged
merged 5 commits into from May 19, 2022

Conversation

artempanko
Copy link
Contributor

Remove DialogAction from LexEvent according to https://docs.aws.amazon.com/lex/latest/dg/lambda-input-response-format.html#using-lambda-input-event-format and align tests with LexResponse model.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #240 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #240     +/-   ##
========================================
+ Coverage   74.59%   74.7%   +0.1%     
========================================
  Files          20      20             
  Lines         681     680      -1     
========================================
  Hits          508     508             
+ Misses        128     127      -1     
  Partials       45      45
Impacted Files Coverage Δ
events/lex.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89e42d...44d5f64. Read the comment docs.

@artempanko
Copy link
Contributor Author

@bmoffatt, please review

@diegobernardes
Copy link
Contributor

diegobernardes commented Oct 23, 2019

Hi @artempanko, thanks for this contribution. We're discussing how we can proceed with this kind of request as it breaks our API compatibility. After we have an update, I'll post here.

@bmoffatt bmoffatt added the breaking change / v2 There is no plan for a v2 release! Alternative non-breaking approaches are strongly encouraged! label Dec 3, 2019
@bmoffatt
Copy link
Collaborator

bmoffatt commented Dec 3, 2019

AWS CodeBuild CI Report

  • CodeBuild project: aws-lambda-go-github-ci
  • Commit ID: 44d5f64
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #240 (af40774) into main (b91101b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   72.01%   72.07%   +0.06%     
==========================================
  Files          19       19              
  Lines        1054     1053       -1     
==========================================
  Hits          759      759              
+ Misses        225      224       -1     
  Partials       70       70              
Impacted Files Coverage Δ
events/lex.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91101b...af40774. Read the comment docs.

@bmoffatt bmoffatt removed the breaking change / v2 There is no plan for a v2 release! Alternative non-breaking approaches are strongly encouraged! label May 18, 2022
@bmoffatt
Copy link
Collaborator

rebased and added a deprecation comment that linters will complain about rather than removing the field

@bmoffatt bmoffatt merged commit 908421f into aws:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants