Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AwsProxyResponseEvent's isBase64Encoded field to boolean primitive type to avoid NullPointer… #449

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

mbfreder
Copy link

…Exception

Issue #, if available:

Description of changes:

Change AwsProxyResponseEvent's isBase64Encoded field to boolean primitive type to avoid NullPointer

Target (OCI, Managed Runtime, both):

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@smirnoal
Copy link
Contributor

will it be false by default? do we have a serialization test for this case?

@mbfreder
Copy link
Author

Yes, it will be false by default. APIGatewayV2HTTPResponse already uses boolean primitive type for that field and there's already a serialization test for that here.

@smirnoal smirnoal merged commit b327b08 into aws:events-v4-serialization-v2 Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants