Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ConnectEvent Queue definition #458

Conversation

offthewall123
Copy link

Issue #, if available:

Description of changes:
Update ConnectEvent Queue definition. According to Amazon Connect latest doc: https://docs.aws.amazon.com/connect/latest/adminguide/connect-lambda-functions.html#function-contact-flow, Queue is an Object. Current type definition is String, which causes parsing error

Cannot deserialize value of type `java.lang.String` from Object value (token `JsonToken.START_OBJECT`)
 at [Source: (ByteArrayInputStream); line: 1, column: 580] (through reference chain: com.amazonaws.services.lambda.runtime.events.ConnectEvent["Details"]->com.amazonaws.services.lambda.runtime.events.ConnectEvent$Details["ContactData"]->com.amazonaws.services.lambda.runtime.events.ConnectEvent$ContactData["Queue"])

*Target (OCI, Managed Runtime, both):Managed Runtime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@msailes
Copy link
Collaborator

msailes commented Oct 30, 2023

Can you change this PR to target the events-v4-serialization-v2 branch please?

Also you'll need to use the Jackson annotations to be able to serialize the capitalised names like ARN, Name, OutboundCallerId, Address and Type.

"Queue": {
    "ARN": "arn:aws:connect:eu-west-2:111111111111:instance/cccccccc-bbbb-dddd-eeee-ffffffffffff/queue/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
    "Name": "PasswordReset"
    "OutboundCallerId": {
        "Address": "+12345678903",
        "Type": "TELEPHONE_NUMBER"
    }
}

@offthewall123 offthewall123 force-pushed the update_ConnectEvent_Queue_definition branch from 4d915f2 to 1723e53 Compare October 31, 2023 01:56
@offthewall123 offthewall123 force-pushed the update_ConnectEvent_Queue_definition branch from 1723e53 to 1a173bd Compare October 31, 2023 01:56
@offthewall123 offthewall123 changed the base branch from main to events-v4-serialization-v2 October 31, 2023 01:58
@offthewall123 offthewall123 changed the base branch from events-v4-serialization-v2 to main October 31, 2023 02:55
@offthewall123
Copy link
Author

Open a new PR based on events-v4-serialization-v2 branch: https://github.com/aws/aws-lambda-java-libs/pull/459/files, close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants