Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ScheduledV2Event implementation #480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

peniakoff
Copy link

and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine.

Issue #, if available:

No. 479: #479

Description of changes:

New Java class ScheduledV2Event has been added. Additionally change is related to APIGatewayV2CustomAuthorizerEventTest which didn't pass on non-US locale Java machine. Now default locale for both tests from this class are running under US-en locale.

Target (OCI, Managed Runtime, both):

both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine
Copy link
Contributor

@smirnoal smirnoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test to aws-lambda-java-tests covering this event

@@ -0,0 +1,366 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the header to

/*
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
*/

@@ -12,6 +14,11 @@ public class APIGatewayV2CustomAuthorizerEventTest {
private static final long TIME_EPOCH = 1601306426515L;
private static final String TIME = "28/Sep/2020:15:14:43 +0000";

@BeforeAll
static void beforeAll() {
Locale.setDefault(new Locale("en", "US"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@peniakoff
Copy link
Author

@smirnoal, done with my last commit.

@smirnoal smirnoal requested review from msailes and andclt May 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants