Prefer core/alloc libs over std #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 95.83% 95.82% -0.01%
==========================================
Files 60 60
Lines 7868 7865 -3
==========================================
- Hits 7540 7537 -3
Misses 328 328 ☔ View full report in Codecov by Sentry. |
justsmth
commented
Feb 16, 2024
justsmth
commented
Feb 16, 2024
| use std::num::TryFromIntError; | ||
| use core::num::TryFromIntError; | ||
| // The Error trait is not in core: https://github.com/rust-lang/rust/issues/103765 | ||
| use std::error::Error; |
There was a problem hiding this comment.
core::error:Error is not yet stable
justsmth
force-pushed
the
prefer-core-alloc
branch
2 times, most recently
from
29d8cd1
to
430930a
Compare
justsmth
force-pushed
the
prefer-core-alloc
branch
from
430930a
to
e4bb0ca
Compare
skmcgrail
approved these changes
Feb 20, 2024
samuel40791765
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.