Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow --container-env-var-file in sync command #7019

Merged
merged 2 commits into from May 13, 2024

Conversation

nitintecg
Copy link
Contributor

@nitintecg nitintecg commented May 4, 2024

Which issue(s) does this change fix?

#6427

Why is this change necessary?

How does it address the issue?

It fixes this issue by allowing --container-env-var-file in sync command similar to build command

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nitintecg nitintecg requested a review from a team as a code owner May 4, 2024 21:09
@github-actions github-actions bot added area/sync sam sync command area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels May 4, 2024
Copy link
Contributor

@mildaniel mildaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good to me!

Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue! LGTM in general, left a small comment there. Let me know if you have any questions!

samcli/commands/sync/command.py Outdated Show resolved Hide resolved
samcli/commands/build/command.py Show resolved Hide resolved
samcli/commands/_utils/options.py Show resolved Hide resolved
samcli/commands/sync/command.py Show resolved Hide resolved
samcli/commands/_utils/options.py Show resolved Hide resolved
@mndeveci mndeveci enabled auto-merge May 13, 2024 20:23
@mndeveci mndeveci added this pull request to the merge queue May 13, 2024
Merged via the queue into aws:develop with commit 0849b2a May 13, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/schema JSON schema file area/sync sam sync command pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants