Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add buildcmd integ test for cargo workspace #7052

Merged
merged 3 commits into from May 14, 2024

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented May 12, 2024

Which issue(s) does this change fix?

aws/aws-lambda-builders#634

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau marked this pull request as ready for review May 13, 2024 23:24
@hawflau hawflau requested a review from a team as a code owner May 13, 2024 23:24
@hawflau hawflau requested review from mildaniel and hnnasit May 13, 2024 23:24
@mndeveci mndeveci changed the title add buildcmd integ test for cargo workspace chore: add buildcmd integ test for cargo workspace May 13, 2024
@mndeveci mndeveci enabled auto-merge May 13, 2024 23:52
@mndeveci mndeveci added this pull request to the merge queue May 13, 2024
Merged via the queue into aws:develop with commit e6e698b May 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants