do NOT serialize empty lists in ec2query

aws · May 6, 2024 · 20c1ea1 · 20c1ea1
1 parent ee219f2
commit 20c1ea1
Show file tree

Hide file tree

Showing 3 changed files with 741 additions and 0 deletions.
diff --git a/...-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/Ec2QueryShapeSerVisitor.java b/...-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/Ec2QueryShapeSerVisitor.java
@@ -3,8 +3,12 @@
 import java.util.Optional;
 import java.util.function.Predicate;
 import software.amazon.smithy.aws.traits.protocols.Ec2QueryNameTrait;
+import software.amazon.smithy.go.codegen.GoWriter;
 import software.amazon.smithy.go.codegen.integration.ProtocolGenerator.GenerationContext;
+import software.amazon.smithy.go.codegen.knowledge.GoPointableIndex;
+import software.amazon.smithy.model.shapes.CollectionShape;
 import software.amazon.smithy.model.shapes.MemberShape;
+import software.amazon.smithy.model.shapes.Shape;
 import software.amazon.smithy.model.shapes.ShapeType;
 import software.amazon.smithy.model.traits.TimestampFormatTrait.Format;
 import software.amazon.smithy.model.traits.XmlNameTrait;
@@ -51,6 +55,14 @@ protected String getSerializedLocationName(MemberShape memberShape, String defau
                 .orElse(defaultValue));
     }
 
+    // EC2Query specifically does not serialize non-nil, empty lists
+    protected void serializeCollection(GenerationContext context, CollectionShape shape) {
+        context.getWriter().get()
+                .write("if len(v) == 0 { return nil }");
+
+        super.serializeCollection(context, shape);
+    }
+
     @Override
     protected boolean isFlattened(GenerationContext context, MemberShape memberShape) {
         // All lists, sets, and maps are flattened in aws.ec2.

diff --git a/internal/protocoltest/ec2query/serializers.go b/internal/protocoltest/ec2query/serializers.go