Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2Query empty list serialization behavior is incorrect #2627

Closed
lucix-aws opened this issue May 2, 2024 · 1 comment · Fixed by #2630
Closed

EC2Query empty list serialization behavior is incorrect #2627

lucix-aws opened this issue May 2, 2024 · 1 comment · Fixed by #2630
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue queued This issues is on the AWS team's backlog

Comments

@lucix-aws
Copy link
Contributor

lucix-aws commented May 2, 2024

A previous change to the query protocols was made to explicitly serialize empty lists as list=. While this is correct for regular query it does not seem to apply to ec2query (which is only used by EC2).

Smithy has corrected this in the protocol tests in smithy-lang/smithy#2269.

My inclination right now is to just revert the behavior without opt-in, since we technically handled it this way before and it only affects the EC2 service.

Related

@lucix-aws lucix-aws added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 This is a high priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels May 2, 2024
@lucix-aws lucix-aws self-assigned this May 2, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant