Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to smithy 1.49 #511

Merged
merged 1 commit into from
May 10, 2024
Merged

upgrade to smithy 1.49 #511

merged 1 commit into from
May 10, 2024

Conversation

lucix-aws
Copy link
Contributor

Upgrade to smithy 1.49 to pull in fixed ec2query protocol tests: aws/aws-sdk-go-v2#2627

Includes some minor code shuffle/deduping in response to having to check for the new (currently unused) STRING_ARRAY endpoint parameter type.

@lucix-aws lucix-aws requested review from a team as code owners May 10, 2024 15:46
@@ -223,4 +223,8 @@ public static boolean isNilable(Symbol symbol) {
|| symbol.getProperty(SymbolUtils.GO_SLICE).isPresent()
|| symbol.getProperty(SymbolUtils.GO_MAP).isPresent();
}

public static Symbol pointerTo(Symbol symbol) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Madrigal Madrigal merged commit 7afc826 into main May 10, 2024
11 checks passed
@lucix-aws lucix-aws deleted the feat-smithy149 branch May 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants