aws/request: Fix bug where the host header would not reflect changes to the endpoint URL. #3102
+199
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
added
the
needs-review
jasdel
approved these changes
Jan 29, 2020
|
will want to add a Change log referencing that bug as well. |
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Feb 4, 2020
=== ### Service Client Updates * `service/cloudfront`: Updates service documentation * Documentation updates for CloudFront * `service/ec2`: Updates service API and documentation * Amazon VPC Flow Logs adds support for 1-minute aggregation intervals. * `service/iot`: Updates service API * Updated ThrottlingException documentation to report that the error code is 400, and not 429, to reflect actual system behaviour. * `service/kafka`: Updates service API, documentation, and paginators * `service/ssm`: Updates service API and documentation * This feature ensures that an instance is patched up to the available patches on a particular date. It can be enabled by selecting the 'ApproveUntilDate' option as the auto-approval rule while creating the patch baseline. ApproveUntilDate - The cutoff date for auto approval of released patches. Any patches released on or before this date will be installed automatically. * `service/storagegateway`: Updates service API * Adding KVM as a support hypervisor * `service/workmail`: Updates service API and documentation * This release adds support for tagging Amazon WorkMail organizations. ### SDK Enhancements * `aws/request`: Add support for EC2 specific throttle exception code * Adds support for the EC2ThrottledException throttling exception code. The SDK will now treat this error code as throttling. ### SDK Bugs * `aws/request`: Fixes an issue where the HTTP host header did not reflect changes to the endpoint URL ([#3102](#3102)) * Fixes [#3093](#3093)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Feb 4, 2020
Release v1.28.10 (2020-02-04) === ### Service Client Updates * `service/cloudfront`: Updates service documentation * Documentation updates for CloudFront * `service/ec2`: Updates service API and documentation * Amazon VPC Flow Logs adds support for 1-minute aggregation intervals. * `service/iot`: Updates service API * Updated ThrottlingException documentation to report that the error code is 400, and not 429, to reflect actual system behaviour. * `service/kafka`: Updates service API, documentation, and paginators * `service/ssm`: Updates service API and documentation * This feature ensures that an instance is patched up to the available patches on a particular date. It can be enabled by selecting the 'ApproveUntilDate' option as the auto-approval rule while creating the patch baseline. ApproveUntilDate - The cutoff date for auto approval of released patches. Any patches released on or before this date will be installed automatically. * `service/storagegateway`: Updates service API * Adding KVM as a support hypervisor * `service/workmail`: Updates service API and documentation * This release adds support for tagging Amazon WorkMail organizations. ### SDK Enhancements * `aws/request`: Add support for EC2 specific throttle exception code * Adds support for the EC2ThrottledException throttling exception code. The SDK will now treat this error code as throttling. ### SDK Bugs * `aws/request`: Fixes an issue where the HTTP host header did not reflect changes to the endpoint URL ([#3102](#3102)) * Fixes [#3093](#3093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net/http.RequestHostmember was only computed during initial request creation. For services such asS3where endpoint modifications occur for referencing buckets using host-style addressing, theHostfield on the HTTP request was not getting updated to reflect changes to theurl.URLHostfield. This change moves the computation of theHostmember during the send step, right before computing the signing signature.