updates golang.org/x/net dependency #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
approved these changes
Jul 5, 2021
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jul 6, 2021
=== ### Service Client Updates * `service/eks`: Updates service API * `service/imagebuilder`: Updates service API and documentation * `service/lambda`: Updates service API, documentation, and examples * Added support for AmazonMQRabbitMQ as an event source. Added support for VIRTUAL_HOST as SourceAccessType for streams event source mappings. * `service/macie2`: Updates service documentation * `service/mgn`: Updates service API * `service/sns`: Updates service documentation and paginators * Documentation updates for Amazon SNS. ### SDK Enhancements * Update golang.org/x/net dependency [#3991](#3991) * Updates the SDK's dependency on golang.org/x/net module dependency.
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jul 6, 2021
Release v1.39.1 (2021-07-06) === ### Service Client Updates * `service/eks`: Updates service API * `service/imagebuilder`: Updates service API and documentation * `service/lambda`: Updates service API, documentation, and examples * Added support for AmazonMQRabbitMQ as an event source. Added support for VIRTUAL_HOST as SourceAccessType for streams event source mappings. * `service/macie2`: Updates service documentation * `service/mgn`: Updates service API * `service/sns`: Updates service documentation and paginators * Documentation updates for Amazon SNS. ### SDK Enhancements * Update golang.org/x/net dependency [#3991](#3991) * Updates the SDK's dependency on golang.org/x/net module dependency.
|
@skotambkar This did not update the transitive x/crypto dependency. The newer version of x/net doesn't depend on x/crypto at all, so the transitive dependency got removed entirely. This actually causes a confusing situation downstream. We have a dependency on another module that in turn depends on an older version of x/crypto. So by upgrading the AWS SDK, we actually downgraded x/crypto. To fix this we need to explicitly add x/crypto as a indirect requirement to retain the newer version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's dependency on
golang.org/x/netmodule to update the transitivegolang.org/x/cryptomodule dependency.