Migration Tool Client Config Part 1: map builder variations to the standard builder #5165
Conversation
|
migration-tool/src/main/java/software/amazon/awssdk/migration/internal/recipe/V1SetterToV2.java
Show resolved
Hide resolved
| if (isV2ClientClass(selectType)) { | ||
| methodName = CLIENT_CONFIG_NAMING_MAPPING.getOrDefault(methodName, methodName); | ||
| } |
There was a problem hiding this comment.
It "feels" weird that we're handling both model classes and client classes in this same code path. It might not be time to do it now, but if we start handling another class of things here we should consider breaking this up and only handling one type of thing at a time.
There was a problem hiding this comment.
Yeah, agreed, I thought about creating a generic class for this. I'll create a TODO for this.
|
|
||
| JavaType.FullyQualified fullyQualified = TypeUtils.asFullyQualified(selectType); | ||
| if (mt != null) { |
There was a problem hiding this comment.
When is this null? (comment?)
There was a problem hiding this comment.
I'm not sure yet! I just know it's nullable by checking recipe code written by openrewrite...
...rc/test/java/software/amazon/awssdk/migration/recipe/V1BuilderVariationsToV2BuilderTest.java
Show resolved
Hide resolved
zoewangg
merged commit 7a638af
into
feature/master/migration-tool
Motivation and Context
This is part 1 of the client config mapping: map builder variations to the standard builder
to
and
to
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License