Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-signed URL duration seconds should not get rounded down #5228

Merged
merged 6 commits into from
May 17, 2024

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented May 16, 2024

Motivation and Context

S3 pre-signed URLs using the old signer AbstractAws4Signer may have the duration in the URL short 1 second due to rounding differences.

Modifications

Use same signing clock when calculating duration, which is what we do in PollyPresigner

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner May 16, 2024 16:20
"category": "Amazon S3",
"contributor": "",
"type": "bugfix",
"description": "Fixes bug where pre-signed URL expiration duration using old signer may get rounded down 1 second"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, old signer -> AwsS3V4Signer

@davidh44 davidh44 enabled auto-merge (squash) May 16, 2024 23:38
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@davidh44 davidh44 merged commit 8d4dae2 into master May 17, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants