feature(Waiters): Add the reason for failure in the exception thrown whenever a waiter transitions to a failure state.

[joviegas]

Motivation and Context

Currently the Waiter fails with below message

software.amazon.awssdk.core.exception.SdkClientException: A waiter acceptor was matched and transitioned the waiter to failure state

Issues like 2262 and also customer requests to add more info whenever a waiter fails. With multiple failure conditionals acceptors, its difficult for the user why exactly the Waiter failed.

This PR makes the exception message to have reason of failure in its message.

Modifications

• Modified the Waiter creation logic so that Message method passes valid message for Failure State transiotion

When Waiter fails due to Response Field

        {
          "state": "failure",
          "matcher": "path",
          "argument": "StringMember",
          "expected": "UNEXPECTED_VALUE"
        },

Error Message

A waiter acceptor with the matcher (path) was matched on parameter (StringMember=UNEXPECTED_VALUE) and transitioned the waiter to failure state.

Failure message for failure due to Status code

        {
          "state": "failure",
          "matcher": "status",
          "expected": 500
        }

Error Message

A waiter acceptor was matched to response status 500 and transitioned the waiter to failure state

Failure message for failure due to Errors

        {
          "matcher": "error",
          "expected": true,
          "state": "failure"
        }

Error Message

A waiter acceptor was matched on error condition (true) and transitioned the waiter to failure state

With Error code causing the failure

        {
          "matcher": "error",
          "expected": "EmptyModeledException",
          "state": "success"
        }

The exception is

A waiter acceptor was matched on error condition (EmptyModeledException) and transitioned the waiter to failure state

Testing

• Junits

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

License

• I confirm that this pull request can be released under the Apache 2 license

[zoewangg]

nit: private?

A waiter acceptor was matched on HTTP response status code (%s) ....

[joviegas]

Updated the message to similar as below suggestion An error waiter acceptor was matched...

[zoewangg]

Looks like we are just missing parentheses around HTTP response status code (%d)

[zoewangg]

Suggesting the following:

An error waiter acceptor with the matcher (%s) was matched on parameter (%s=%s) and 
transitioned the waiter to failure state.

[joviegas]

Was wondering why error waiter acceptor and not just waiter acceptor since the marcher is based on path and not a error matcher

[zoewangg]

My thinking was that it's an error waiter acceptor because it leads the request to failure. I can see how it's confusing. NVM then!

[zoewangg]

Suggesting the following:

An error waiter acceptor was matched on error condition (%s) and ...

[sonarcloud]

Quality Gate failed

Failed conditions
37.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud