Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReceiveMessageBatchTask messages to be stored and removed in fifo order #2623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmbotts
Copy link

@kmbotts kmbotts commented Aug 5, 2021

Issue #, if available:
n/a

Description of changes:
Messages retrieved by spawned Receive task are removed in reverse order. Updated to have them polled in order as they were received. This was not intended to make the Amazon SQS Buffered Asynchronous Client fully support FIFO queues, but it's a step in that direction.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kmbotts
Copy link
Author

kmbotts commented Aug 5, 2021

Not necessarily in FIFO order, just the order they were received from queue. If that were to be a FIFO queue, then the order is preserved prior to fulfilling the future back to the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant