Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): add script to eslint --fix clients source code #2838

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 28, 2021

Issue

N/A

Description

Adds script to eslint --fix source code for clients.

Before
$ time yarn generate-clients
...
Done in 70.78s.
yarn generate-clients  10.71s user 2.41s system 18% cpu 1:10.91 total
After
$ time yarn generate-clients
...
Done in 394.65s.
yarn generate-clients  407.29s user 13.74s system 106% cpu 6:34.78 total

Testing

Verified that source code is linted in #2839


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft September 28, 2021 05:20
@trivikr
Copy link
Member Author

trivikr commented Sep 28, 2021

This PR can be re-attempted after an option to lint in parallel in introduced in eslint:

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #2838 (71a4b0a) into main (7e634cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2838   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         554      554           
  Lines       28886    28886           
  Branches     7072     7072           
=======================================
  Hits        17453    17453           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e634cf...71a4b0a. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Sep 28, 2021

This PR can be re-attempted after an option to lint in parallel in introduced in eslint:

Another option is to use @node-rs/deno-lint
Update: deno-lint doesn't support --fix

@trivikr
Copy link
Member Author

trivikr commented Sep 29, 2021

Superceded by #2846

@trivikr trivikr closed this Sep 29, 2021
@trivikr trivikr deleted the eslint-client-code branch September 29, 2021 05:23
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants