Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove unsupported version deprecation warning #4124

Closed

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 31, 2022

Issue

No longer needed, as Node.js 12.x support is removed in #4123

Description

Removes call to unsupported version deprecation warning in runtimeConfig

Testing

Verified that warning is no longer emitted:

// test.js
const { DynamoDB } = require("../aws-sdk-js-v3/clients/client-dynamodb");
const { S3 } = require("../aws-sdk-js-v3/clients/client-s3");

const dynamodbClient = new DynamoDB();
const s3Client = new S3();
$ fnm use 12
Using Node v12.22.12

# No warning is emitted
$ node test.js

Additional context

Related smithy-lang/smithy-typescript#624


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the remove-unsupported-version-emit-warning branch from 5ed9ede to 9a23998 Compare October 31, 2022 20:32
@trivikr trivikr marked this pull request as ready for review October 31, 2022 22:06
@trivikr trivikr requested a review from a team as a code owner October 31, 2022 22:06
@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2022

Superceded by #4127

@trivikr trivikr closed this Nov 1, 2022
@trivikr trivikr deleted the remove-unsupported-version-emit-warning branch November 1, 2022 02:23
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants