Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): extend TypeScript config from @tsconfig/node14 #4125

Merged
merged 5 commits into from Nov 1, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 31, 2022

Issue

Internal JS-3680

With end of support for Node.js 12.x in #4123, and end of support for Internet Explorer 11 in #4006, we're extending TypeScript Config from @tsconfig/node14

In future, the browser versions supported can be extended from last LTS versions of Node.js, when support for end-of-life Node.js LTS versions are dropped.

Description

Extends TypeScript config from @tsconfig/node14

Testing

Verified using https://github.com/aws-samples/aws-sdk-js-tests

# In aws-sdk-js-v3
$ client-cognito-identity> npm pack
...
aws-sdk-client-cognito-identity-3.200.0.tgz

$ client-dynamodb> npm pack
...
aws-sdk-client-dynamodb-3.200.0.tgz

$ credential-provider-cognito-identity> npm pack
...
aws-sdk-credential-provider-cognito-identity-3.200.0.tgz
# In aws-sdk-js-tests
$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-cognito-identity/aws-sdk-client-cognito-identity-3.200.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-dynamodb/aws-sdk-client-dynamodb-3.200.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/packages/credential-provider-cognito-identity/aws-sdk-credential-provider-cognito-identity-3.200.0.tgz

# Update packages/utils/src/config.js
$ aws-sdk-js-tests> yarn start:node
# successful listTables call from DynamoDB printed on console

$ aws-sdk-js-tests> yarn start:web
# successful listTables call from DynamoDB shown in browser

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 31, 2022 22:43
@trivikr trivikr requested a review from a team as a code owner October 31, 2022 22:43
@trivikr trivikr merged commit fb91765 into aws:main Nov 1, 2022
@trivikr trivikr deleted the use-tsconfig-node14-clients branch November 1, 2022 00:05
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants