Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(private): add server artifacts #4159

Merged
merged 8 commits into from Nov 9, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 9, 2022

Issue

Server artifacts can now be added as support for Node.js 12.x ended in #4123

Description

Adds server artifacts in private workspace

Testing

Verified that:

  • Server protocol tests are run in CodeBuild CI, and are successful
    lerna info run Ran npm script 'test' in '@aws-sdk/aws-restjson-server' in 17.1s:
    ...
    lerna info run Ran npm script 'test' in '@aws-sdk/aws-restjson-validation-server' in 7.1s:
  • Server artifacts are updated when yarn generate-clients is called without option n
  • Server artifacts have "private": true which ensures they won't be mistakenly published

Additional Context

The generic client aws-echo-service was added in #2950


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(private): add server artifacts feat(private): add server artifacts Nov 9, 2022
@trivikr trivikr marked this pull request as ready for review November 9, 2022 23:07
@trivikr trivikr requested a review from a team as a code owner November 9, 2022 23:07
@adamthom-amzn adamthom-amzn self-requested a review November 9, 2022 23:22
@trivikr trivikr merged commit e70f472 into aws:main Nov 9, 2022
@trivikr trivikr deleted the server-artifacts branch November 9, 2022 23:25
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants