Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-dynamodb): preserve collections when serializing class instances to map #5826

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Feb 26, 2024

Issue

#5824

Description

  • remove copy function used when convertClassInstanceToMap=true
  • functions are filtered out of serialization in other steps instead

Testing

existing tests + added unit test

@kuhe kuhe marked this pull request as ready for review February 26, 2024 20:22
@kuhe kuhe requested a review from a team as a code owner February 26, 2024 20:22
@kuhe kuhe merged commit e1ba507 into aws:main Feb 26, 2024
3 of 4 checks passed
@kuhe kuhe deleted the fix/lib-dynamodb branch February 26, 2024 21:05
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants