feat(core): add AccountIdEndpointMode config option #6036
+348
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
changed the title
siddsriv
commented
May 14, 2024
| if (isAwsService(settings, model) && target.equals(LanguageTarget.NODE)) { | ||
| writer.addDependency(AwsDependency.AWS_SDK_CORE); | ||
| writer.addImport("emitWarningIfUnsupportedVersion", "awsCheckVersion", AwsDependency.AWS_SDK_CORE); | ||
| writer.write("awsCheckVersion(process.version);"); |
There was a problem hiding this comment.
want to confirm importing /core here is okay, since a chunk of this work will be placed in /core itself
siddsriv
commented
May 15, 2024
| switch (target) { | ||
| case BROWSER: | ||
| runtimeConfigs.put("accountIdEndpointMode", writer -> { | ||
| writer.addDependency(TypeScriptDependency.CONFIG_RESOLVER); |
There was a problem hiding this comment.
this dependency should be for core instead, if we were to place defaults and resolver in core instead of the config-resolver package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-4633
Part 3
Description
Adds support for
AccountIdEndpointModeconfig option. (client config, env, config file)Testing
Checklist
@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.