Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ieee754 to 1.1.13 #2850

Merged
merged 1 commit into from Sep 18, 2019
Merged

Pin ieee754 to 1.1.13 #2850

merged 1 commit into from Sep 18, 2019

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Sep 16, 2019

This is a follow-up for #1979 as the upstream fixed the problem, which confirmed at feross/ieee754#17 (comment) .

Upstream diff: feross/ieee754@v1.1.8...v1.1.13

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • non-code related change (markdown/git settings etc)

cf. aws#1979

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir changed the title Pin ieee754 to 1.1.13 as the problem was resolved on upstream Pin ieee754 to 1.1.13 Sep 16, 2019
@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #2850 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2850   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files         300      300           
  Lines        8991     8991           
  Branches     1676     1676           
=======================================
  Hits         8718     8718           
  Misses        273      273

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e52eb...0faca3a. Read the comment docs.

@trivikr
Copy link
Member

trivikr commented Sep 17, 2019

The issue in #1977 was fixed in #1979
What's the issue being fixed in this PR?

@tnir
Copy link
Contributor Author

tnir commented Sep 17, 2019

@trivikr Just update the ieee754 package to the latest: feross/ieee754@v1.1.8...v1.1.13

Some other packages are moving to the latest (namely 1.1.13) so a user of application would have only a single version of ieee754 package.

@trivikr trivikr merged commit 3cf0512 into aws:master Sep 18, 2019
@tnir tnir deleted the update-ieee-to-1.1.13 branch September 18, 2019 23:33
@lock
Copy link

lock bot commented Sep 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants