feat: cloudformation linter #4081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Pat Myron <PatMyron@users.noreply.github.com>
…ation-linter # Conflicts: # resources/resources/software/aws/toolkits/resources/localized_messages.properties
…oints to the right executable name
…i/aws-toolkit-jetbrains into feature-cloudformation-linter
…ation-linter # Conflicts: # jetbrains-core/resources/META-INF/plugin.xml # jetbrains-core/src/software/aws/toolkits/jetbrains/core/help/HelpIds.kt # jetbrains-core/src/software/aws/toolkits/jetbrains/settings/AwsSettingsConfigurable.java
miparnisari
force-pushed
the
feature-cloudformation-linter-v2
branch
from
298662a
to
3cca60a
Compare
|
miparnisari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive #1715. It needs to be brought up to date.
Types of changes
Description
Add CloudFormation linter. Among other things, it provides:
DeletionPolicy / UpdateReplacePolicyHow this PR works: it's a file annotator. If the file currently open isn't recognized as a CloudFormation template, it doesn't do anything. Otherwise, it tries to run the template through
cfn-lint(a Python package). If errors are found, they are displayed inline.Motivation and Context
There are plugins out there that do this same thing, e.g. https://github.com/binxio/cfn-lint-plugin. I would like to have this functionality within the official AWS plugin.
Related Issue(s)
N/A
Testing
Tested on Mac OS with IntelliJ Ultimate 2020 and on Windows 10.
Screenshot
Checklist
gradlew checksucceedsLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.