Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typesafe messages sent from login browser #4405

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

typesafe messages sent from login browser #4405

wants to merge 12 commits into from

Conversation

Will-ShaoHua
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua changed the title [wip] making messages from login browser type safed [wip not required for 4/30] making messages from login browser type safed Apr 29, 2024
@rli rli changed the base branch from feature/q-extension to main April 29, 2024 21:12
@Will-ShaoHua Will-ShaoHua changed the title [wip not required for 4/30] making messages from login browser type safed [wip not required for 4/30] making messages from login browser type safe Apr 29, 2024
@Will-ShaoHua Will-ShaoHua changed the title [wip not required for 4/30] making messages from login browser type safe [wip] making messages from login browser type safe May 6, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review May 15, 2024 06:52
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners May 15, 2024 06:52
@Will-ShaoHua Will-ShaoHua changed the title [wip] making messages from login browser type safe making messages from login browser type safe May 15, 2024
@Will-ShaoHua Will-ShaoHua changed the title making messages from login browser type safe typesafe messages sent from login browser May 15, 2024
@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Will-ShaoHua Will-ShaoHua marked this pull request as draft May 21, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Will-ShaoHua @rli