Amazon Q: Added telemetry metrics and modified customer facing messages for Q Codescans. #4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishrp-aws
reviewed
May 8, 2024
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanManager.kt
Show resolved
Hide resolved
ashishrp-aws
reviewed
May 9, 2024
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanManager.kt
Show resolved
Hide resolved
ashishrp-aws
reviewed
May 9, 2024
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanManager.kt
Show resolved
Hide resolved
ashishrp-aws
reviewed
May 9, 2024
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanSession.kt
Outdated
Show resolved
Hide resolved
ashishrp-aws
reviewed
May 9, 2024
...ws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
Show resolved
Hide resolved
ashishrp-aws
approved these changes
May 9, 2024
laileni-aws
changed the title
ashishrp-aws
approved these changes
May 9, 2024
manodnyab
reviewed
May 13, 2024
| val connection = it.connection as HttpURLConnection | ||
| connection.setFixedLengthStreamingMode(fileToUpload.length()) | ||
| IoUtils.copy(fileToUpload.inputStream(), connection.outputStream) | ||
| } catch (e: IOException) { |
There was a problem hiding this comment.
Why do we catch and rethrow here?
There was a problem hiding this comment.
Removed try catch at parent function createUploadUrlAndUpload and tried to add this at individual step to get precise error message to telemetry.
There was a problem hiding this comment.
Do we need the catch blocks here?
There was a problem hiding this comment.
There is a potential chance of IOException so I handled IOException too in the catch block. We need catch block to throw uploadArtifactFailedError if required, we can remove catch for IOException.
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanSession.kt
Outdated
Show resolved
Hide resolved
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanSession.kt
Outdated
Show resolved
Hide resolved
...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanSession.kt
Show resolved
Hide resolved
manodnyab
reviewed
May 14, 2024
| val connection = it.connection as HttpURLConnection | ||
| connection.setFixedLengthStreamingMode(fileToUpload.length()) | ||
| IoUtils.copy(fileToUpload.inputStream(), connection.outputStream) | ||
| } catch (e: IOException) { |
There was a problem hiding this comment.
Do we need the catch blocks here?
| @@ -168,6 +169,15 @@ class CodeWhispererCodeFileScanTest : CodeWhispererCodeScanTestBase(PythonCodeIn | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
I thought to write test for both File scan and project scan but removed this.
rli
approved these changes
May 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Solution
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.