Fix flaky test mavenRootPomHandlerBaseDirIsCorrect
#4452
Conversation
|
/retryBuild |
|
/retryBuilds |
vchikoti1998
changed the title
mavenRootPomHandlerBaseDirIsCorrect
| @@ -61,7 +61,7 @@ class JavaLambdaBuilderTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun mavenRootPomHandlerBaseDirIsCorrect() = runTest { | |||
| fun mavenRootPomHandlerBaseDirIsCorrect(): Unit = runBlocking { | |||
There was a problem hiding this comment.
will revert it
There was a problem hiding this comment.
discussed offline, the issue is with runTest and the fix is in a later version of coroutines-test
gradle/libs.versions.toml
Outdated
| @@ -17,7 +17,7 @@ junit5 = "5.10.2" | |||
| # https://kotlinlang.org/docs/releases.html#release-details | |||
| kotlin = "1.9.23" | |||
| # set in <root>/settings.gradle.kts | |||
| kotlinCoroutines = "1.7.3" | |||
| kotlinCoroutines = "1.8.0" | |||
There was a problem hiding this comment.
coroutines can't be safely bumped like this
https://github.com/aws/aws-toolkit-jetbrains/blob/main/kotlinResolution.settings.gradle.kts
| @@ -61,7 +61,7 @@ class JavaLambdaBuilderTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun mavenRootPomHandlerBaseDirIsCorrect() = runTest { | |||
| fun mavenRootPomHandlerBaseDirIsCorrect(): Unit = runBlocking { | |||
There was a problem hiding this comment.
it would also be good to add a comment in the source code explaining why we're using runBlocking
| fun mavenRootPomHandlerBaseDirIsCorrect(): Unit = runBlocking { | |
| fun mavenRootPomHandlerBaseDirIsCorrect() = runBlocking { |
There was a problem hiding this comment.
sure Definitely, will add a comment.
mavenRootPomHandlerBaseDirIsCorrect() method signature can't be removed its not taking Unit as default
|
Types of changes
Description
The test case mavenRootPomHandlerBaseDirIsCorrect() was updated to use
runBlockinginstead ofrunTest.runBlockingis a Kotlin coroutines function that helps bridge regular blocking code (code that stops the current thread)with coroutine based code (code that suspends execution and allows other tasks to run concurrently).
Using
runBlockingresolved the issue with uncaught exceptions that was occurring when using the more specializedrunTestfunction.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.