Adding ChangeListManager to parse ignored Files in Project and sortin… #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g through project modules for accurate file parsing.
rli
reviewed
May 9, 2024
|
|
||
| if (!current.isDirectory) { | ||
| // Using both featureDevSessionContext and changeListManager to ignore files. | ||
| // featureDevSessionContext is used to only ignore files in gitignore in project root and uses regex pattern matching. |
There was a problem hiding this comment.
why wouldn't we just rely on ChangeListManager? it is already gitignore aware
There was a problem hiding this comment.
its not checking gitignore files in tests. so thought it'd be prudent to keep both in. i was trying choose to leave featureDevSessionContext in or out.
...ws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
Outdated
Show resolved
Hide resolved
...ws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
May 13, 2024
Comment on lines
-381
to
-385
|
|
||
| // Adding gitignore file and gitignore file member for testing. | ||
| // The tests include the markdown file but not these two files. | ||
| projectRule.fixture.addFileToProject("/.gitignore", "node_modules\n.idea\n.vscode\n.DS_Store").virtualFile | ||
| projectRule.fixture.addFileToProject("test.idea", "ref: refs/heads/main") |
There was a problem hiding this comment.
Ack. i have been working to write tests including gitignore files.
|
Will-ShaoHua
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g through project modules for accurate file parsing.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.