fix flaky behaviour [ Test load tab state] #4454
Conversation
| AwsToolkitExplorerToolWindow.DEVTOOLS_TAB_ID | ||
| } | ||
| ) | ||
| assertThat(sut.state.selectedTab).isEqualTo(AwsToolkitExplorerToolWindow.Q_TAB_ID) |
There was a problem hiding this comment.
Should this test change now that user can dismiss the Q tab?
There was a problem hiding this comment.
In this we are just testing whether Q_TAB is selected or not. Actually this test passes but sometimes fails on CI and local. So, running this test in runInEdtAndGet {} block. To avoid flakiness.
Should this test change now that user can dismiss the Q tab?
I think this is an another test case, isn't it?
There was a problem hiding this comment.
per discussion with Ankit, leave default to be Q_TAB
There was a problem hiding this comment.
Default tab selected should be Q_TAB, checked with @ankit-sharma90
|
/retryBuilds |
|
Types of changes
Description
The test is failing because the loadState is being called out of runInEdt. When runInEdt is added, thread safety is enforced and the test passes.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.