fix(amazonq): do not include plan generation and code generation durations in createUpload telemetry event for /dev #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions in createUpload telemetry event for /dev
|
kumsmrit
reviewed
May 13, 2024
| @@ -49,10 +50,11 @@ class PrepareCodeGenerationState( | |||
| ) | |||
|
|
|||
| uploadArtifactToS3(uploadUrlResponse.uploadUrl(), fileToUpload, zipFileChecksum, zipFileLength, uploadUrlResponse.kmsKeyArn()) | |||
| deleteUploadArtifact(fileToUpload) | |||
There was a problem hiding this comment.
Why have we added delete here as well ?
There was a problem hiding this comment.
We didn't add delete here, just moved it from below (line#64) to here to have file-related actions next to each other before starting to init next state similar to how it is done in PrepareRefinementState.kt
kumsmrit
approved these changes
May 13, 2024
sannicm
reviewed
May 13, 2024
| @@ -80,5 +79,7 @@ class PrepareCodeGenerationState( | |||
| credentialStartUrl = getStartUrl(config.featureDevService.project) | |||
| ) | |||
| } | |||
| // It is essential to interact with the next state outside of try-catch block for the telemetry to capture events for the states separately | |||
| return nextState.interact(action) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
As we were doing
nextState.interact() insidetry-catchblock, the duration for createUpload event was including duration for plan generation and code generation, too. It wasn't intended.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.