New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(S3 View): Display bucket contents with specific IAM role policies #4644
Open
avsthiago
wants to merge
4
commits into
aws:master
Choose a base branch
from
avsthiago:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icies Problem: S3 tree view doesn't show contents with specific IAM role policies. Prefix parameter was null.\n\nSolution: Set Prefix parameter to an empty string as default. Allows bucket contents display if root prefix is allowed.
justinmk3
reviewed
Apr 10, 2024
justinmk3
reviewed
Apr 10, 2024
justinmk3
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clear root-cause analysis in #4643 , that is very helpful.
ivikash
reviewed
Apr 11, 2024
ivikash
approved these changes
Apr 14, 2024
@ivikash, @justinmk3 thanks for your approvals. Do you know how to proceed with the PR checks? There is an approval pending to allow the MacOS and Windows builds to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
S3 tree view doesn't show contents with specific IAM role policies. Prefix parameter was null.
Solution:
Set Prefix parameter to an empty string as default. Allows bucket contents display if root prefix is allowed.
Related issue:
#4643 S3 Tree View Not Displaying Bucket Contents with Specific IAM Role Policies
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.