fix(codecatalyst): menu command fails after using tree node

[justinmk3]

Problem:

The codecatalyst commands:

"Open Dev Environment"
"Clone Repository"

fail if their menu forms are used AFTER the treenode forms.

Steps to reproduce:

1. click the "Open Dev Environment" tree node in the codecatalyst panel.
2. close the wizard.
3. in the codecatalyst panel, expand the "..." root menu and choose "Open CodeCatalyst Dev Environment"
4. it fails because the TreeNode from step (1) is passed as the first arg, which breaks openDevEnv().

Solution:

Follow the instructions from the VsCodeCommandArg docstring:

aws-toolkit-vscode/packages/core/src/shared/vscode/commands2.ts

Lines 23 to 41 in 4decdf6

	/**
	* HACK
	*
	* If a command matches the following conditions:
	* - Is registered with VS Code
	* - Has args for the execution of the command
	* - Can be executed through a package.json contribution (eg: ellipsis menu in View)
	*
	* Then unexpected args will be passed to the command.
	* - Currently it sets arg[0] to an object or undefined, depending on the context.
	* - And the rest of the args will be undefined do not exist.
	* ---
	* **So as a workaround**, commands who meet the above criteria should
	* - have this type as their first arg as a placeholder
	* - When executing the command from within the code, pass in {@link placeholder} as the first arg.
	* - In the command check if the first arg !== {@link placeholder}, and if so you will need to
	* set values for the other args since they will not exist.
	*/
	export type VsCodeCommandArg = typeof placeholder

TODO:

Note that the bug does NOT occur if you use the "..." menu command FIRST. It seems like the TreeNode is stored as state on the CommandResource; is that actually necessary?

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.