fix(csharpSamDebug): remove debug mode for arm64 #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsdbg is not supported for arm64 architecture
|
/runIntegrationTests |
hayemaxi
approved these changes
May 24, 2024
Is there a reference we can mention, in case we need to revisit this in the future? |
|
Tracking the PR to re-enable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
sam localis invoked forcSharp, the invocation gets blocked when trying to attach a debugger.vsdbgis not supported forarm64architecture.ref #4749
Solution
Disable
debugmode for cases when the template architecture isarm64or the developer is usingarm64architecture machines, for eg - Apple M1/M2/M3 chips.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.