New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Amazon Q Code Transform: Enforce valid JDK for user provided JAVA_HOME #4945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arangatang
changed the title
[WIP] - Amazon Q Code Transform: Enforce valid JDK for user provided JAVA_HOME
Amazon Q Code Transform: Enforce valid JDK for user provided JAVA_HOME
May 7, 2024
JuliaABurch
reviewed
May 7, 2024
damntrecky
approved these changes
May 7, 2024
dhasani23
reviewed
May 7, 2024
Moved back to draft mode -> Discussed with team, i'll split this into two parts.
|
arangatang
force-pushed
the
enforce-valid-jdk
branch
from
May 10, 2024 10:17
d84063e
to
5260634
Compare
Force push due to rebase against master. |
dhasani23
reviewed
May 10, 2024
Failing test seem to be flaky and is unrelated. |
Having some discussion internally if this is the way we want to go forward with this, so moving to draft mode to avoid accidental merges until this is decided. |
arangatang
changed the title
Amazon Q Code Transform: Enforce valid JDK for user provided JAVA_HOME
[WIP] - Amazon Q Code Transform: Enforce valid JDK for user provided JAVA_HOME
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of the Code Transformation Process, users can provide a custom JAVA_HOME. Previously we only verified if the default JAVA_HOME was correctly detected and not this user provided JAVA_HOME.
This meant customers could pass an invalid JDK which could lead to the following problems:
Secondary problem - Bugfix
Extracted to #4949
Solution
tabId
totabID
- Extracted to Fix bug where messages to chat got lost. #4949Screenshots
Screenshots for main problem
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.