Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): re-use existing connections if provided manually #4973

Merged
merged 3 commits into from May 13, 2024

Conversation

hayemaxi
Copy link
Contributor

@hayemaxi hayemaxi commented May 10, 2024

  • If the user enters start url and region of an already existing connection that was displayed, we will just proceed with re-using that connection.
  • If the user enters start url but region differs from what exists, we will display the error.

Other misc fixes:

  • fix(toolkit): return to explorer if login page is exited
  • fix(codecatalyst): use default scopes (includes aws account scopes) for sign in

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- If the user enters start url and region of an already existing connection that was displayed, we will just proceed with re-using that connection.
- If the user enters start url but region differs from what exists, we will display the error.
@hayemaxi hayemaxi requested a review from a team as a code owner May 10, 2024 16:40
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if some of these logs are noisy, may want to use a logOnce pattern

@hayemaxi hayemaxi merged commit fade41d into aws:master May 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants