Avoid nanosecond-resolution time where not needed #224
+39
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Instant#now` returns an Instant with nanonsecond-level resolution. The ns-level timer isn't cheap, and is always discarded in X-Ray's code. We can avoid much of this cost by swapping out `Instant#now` with `System#currentTimeMillis`.
anuraaga
approved these changes
Oct 8, 2020
aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/internal/TimeUtils.java
Outdated
Show resolved
Hide resolved
…ternal/TimeUtils.java
|
Thanks @rhernandez35 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instant#nowreturns an Instant with nanonsecond-level resolution. Thens-level timer isn't cheap, and is always discarded in X-Ray's code. We
can avoid much of this cost by swapping out
Instant#nowwithSystem#currentTimeMillis.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.