Send subsegments separately from segments when the serialized size is larger than the UDP packet size limit #344
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kurru
force-pushed
the
send-subsegments-when-large
branch
2 times, most recently
from
9410406 to
9554acb
Compare
…ger than the UDP packet size limit. This is similar to how the DefaultStreamingStrategy behaves. Segments occasionally can be too large and contain hundreds subsegments, despite the behavior of the DefaultStreamingStrategy class, when running with multiple threads. It is suspected that race conditions can lead to subsegments building up and not getting pushed into xray daemon by the time the segment is ended.
Kurru
force-pushed
the
send-subsegments-when-large
branch
from
9554acb to
a435ea1
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
============================================
- Coverage 58.95% 58.82% -0.13%
Complexity 1207 1207
============================================
Files 131 131
Lines 5065 5076 +11
Branches 592 594 +2
============================================
Hits 2986 2986
- Misses 1806 1817 +11
Partials 273 273
Continue to review full report at Codecov.
|
wangzlei
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#26
Description of changes:
Send subsegments separately from segments when the serialized size is larger than the UDP packet size limit. This is similar to how the DefaultStreamingStrategy behaves.
Segments occasionally can be too large and contain hundreds subsegments, despite the behavior of the DefaultStreamingStrategy class, when running with multiple threads. It is suspected that race conditions can lead to subsegments building up and not getting pushed into xray daemon by the time the segment is ended.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.