Skip to content

Add @Nullable to AWSXray.setTraceEntity() parameter #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

Kurru
Copy link
Contributor

@Kurru Kurru commented Jul 28, 2022

Issue #, if available:
N/A

Description of changes:
Add @nullable to AWSXray.setTraceEntity() parameter as the delegate method in AWSXrayRecorder accepts nulls when clearing the TraceEntity state.

This will resolve a 'null check' warning in IntelliJ Argument 'original' might be null.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Kurru Kurru requested a review from a team as a code owner July 28, 2022 00:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…WSXrayRecorder accepts nulls when clearing the TraceEntity state
@Kurru Kurru force-pushed the nullable-setTraceEntity branch from 6d853b9 to 1d68f4f Compare July 28, 2022 00:31
Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jj22ee jj22ee merged commit 5bab3e5 into aws:master Aug 5, 2022
@Kurru Kurru deleted the nullable-setTraceEntity branch August 5, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants