Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No class def found error #375

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

atshaw43
Copy link
Contributor

Issue #, if available:

Description of changes:
If a module is needed to serialize an object in Jackson, but it does not exist, then it causes a NoClassDefFoundError

This change will log that error and log which modules are loaded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atshaw43 atshaw43 requested a review from a team as a code owner March 14, 2023 23:50
@codecov-commenter
Copy link

Codecov Report

Merging #375 (91825f1) into master (683898a) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     58.26%   58.27%           
- Complexity     1272     1273    +1     
=========================================
  Files           138      138           
  Lines          5247     5253    +6     
  Branches        633      634    +1     
=========================================
+ Hits           3057     3061    +4     
- Misses         1894     1896    +2     
  Partials        296      296           
Impacted Files Coverage Δ
...n/java/com/amazonaws/xray/entities/EntityImpl.java 83.77% <71.42%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atshaw43 atshaw43 merged commit d107573 into aws:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants