Swap capi CRD race condition patch for CR bump #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XL
g-gaston
force-pushed
the
capi-1.6.0-remove-crd-patch-bump-controller-runtime
branch
from
d850144
to
5688743
Compare
The bug has been fixed in controller-runtime so now we don't need to detect the error and restart the pod. This CR bump is already merged in capi 1.6, once the new patch is out in a couple weeks, we can remove this new patch and update capi.
g-gaston
force-pushed
the
capi-1.6.0-remove-crd-patch-bump-controller-runtime
branch
from
5688743
to
3a60a06
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The bug has been fixed in controller-runtime so now we don't need to detect the error and restart the pod. This CR bump is already merged in capi 1.6, once the new patch is out in a couple weeks, we can remove this new patch and update capi.
The fix for CR 0.16: kubernetes-sigs/controller-runtime#2677
Improvements related to this issue for CR moving forward (available in future capi 1.7): kubernetes-sigs/controller-runtime#2663
Capi bump: kubernetes-sigs/cluster-api#10132
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.