Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty commits with GoGit update #7359

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

taneyland
Copy link
Member

Issue #, if available:

Description of changes:
We updated the go-git version which now returns an error on commits with no changes. Adding this new commit option to keep our same behavior. See more here:
go-git/go-git#623

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (324a314) 71.77% compared to head (cdb02e4) 71.77%.
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/git/gitclient/gitclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7359      +/-   ##
==========================================
- Coverage   71.77%   71.77%   -0.01%     
==========================================
  Files         560      560              
  Lines       43495    43496       +1     
==========================================
  Hits        31220    31220              
- Misses      10556    10557       +1     
  Partials     1719     1719              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@taneyland taneyland merged commit 7540251 into aws:main Jan 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants