Remove SKIPPED_TESTS.yaml file
#7747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go already has a construct for skipping tests: `t.Skip`. This file based method to skip tests is unnecessary, adds unnecessary code, and is yet another piece of domain knowledge that is not documentated anywhere and difficult to understand its scope and use. By adding `t.Skip` to all tests that need to be skipped we eliminate all of these concerns. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7747 +/- ##
==========================================
+ Coverage 73.48% 73.60% +0.11%
==========================================
Files 579 588 +9
Lines 36357 37149 +792
==========================================
+ Hits 26718 27344 +626
- Misses 7875 8013 +138
- Partials 1764 1792 +28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Go already has a construct for skipping tests:
t.Skip. This file based method to skip tests is unnecessary, adds unnecessary code, and is yet another piece of domain knowledge that is not documentated anywhere and difficult to understand its scope and use. By addingt.Skipto all tests that need to be skipped we eliminate all of these concerns. With this we do remove the functionality of e2e tests being skipped at runtime via a file. This is a trade off I'm comfortable taking on because of the benefits described above.Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.