New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc for Kubelet Configuration #7995
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7995 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 577 577
Lines 35862 35862
=======================================
Hits 26341 26341
Misses 7855 7855
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: file name typo
Resolv Conf (DNS) - clusterNetwork.dns.resolvConf | ||
Node labels (CP and MD) - controlPlaneConfiguration.labels; workerNodeGroupConfigurations.labels | ||
``` | ||
#### PROPOSED SOLUTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend having a single section for proposed and alternate solutions. You can have multiple sub-sections within each of them for different scenarios/usecases
Issue #, if available:
Documentation added/planned (if applicable):
Doc for Kubelet Configuration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.