Add missing doc and tests for multi-key commands #1391

Yury-Fridlyand · 2024-05-07T19:50:13Z

Issue #, if available:
N/A

Description of changes:

Add cross-slot notice for multi-key commands - which can handle it and which can not
Add tests
For all clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Add missing doc and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework docs and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Linter Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

jonathanl-bq

Left some minor comments.

java/client/src/main/java/glide/api/commands/GenericBaseCommands.java

node/src/BaseClient.ts

python/python/glide/async_commands/core.py

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand · 2024-05-10T01:07:13Z

I wanted to emphasize hash slot, but then we decided not to do that in python client, so I removed it everywhere. Thank you for catching that.

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand · 2024-05-10T02:02:12Z

Should be merged after #1390

java/client/src/main/java/glide/api/commands/HyperLogLogBaseCommands.java

java/client/src/main/java/glide/api/commands/SetBaseCommands.java

java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java

node/src/BaseClient.ts

python/python/glide/async_commands/core.py

node/src/BaseClient.ts

python/python/tests/test_async_client.py

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java

python/python/glide/async_commands/core.py

node/src/BaseClient.ts

python/python/glide/async_commands/core.py

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

node/tests/RedisClusterClient.test.ts

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand · 2024-05-13T23:50:06Z

@shohamazon please, review and merge if it is OK for you.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

java/client/src/main/java/glide/api/commands/HyperLogLogBaseCommands.java

java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java

shohamazon · 2024-05-15T11:16:47Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

@@ -2171,6 +2171,8 @@ public T zinterstore(
     * To perform a <code>zinterstore</code> operation while specifying aggregation settings, use
     * {@link #zinterstore(String, KeysOrWeightedKeys, Aggregate)}
     *
+     * @apiNote When in cluster mode, <code>destination</code> and all <code>keysOrWeightedKeys</code>


Suggested change

* @apiNote When in cluster mode, <code>destination</code> and all <code>keysOrWeightedKeys</code>

* @apiNote When in cluster mode, <code>destination</code> and all keys <code>keysOrWeightedKeys</code>

why is this command the only one modified in this file? what about the other zinterstore and the rest of the commands?

Oh, that's a mistake - we don't add same-slot notice to transaction, because it is routed to a single node only.
We don't add that to docs in transaction on other clients too.
If you want me to add - please tell.

I think we should, but whatever you think right

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Hotfix for #1391 - resolving conflict with #1419. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand added 2 commits May 7, 2024 12:45

Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad…

4ab284f

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand added python node java issues and fixes related to the java client docs Documentation labels May 7, 2024

Yury-Fridlyand requested review from GumpacG, aaron-congo, jonathanl-bq, barshaul, acarbonetto, tjzhang-BQ, shohamazon and ikolomi May 7, 2024 19:50

Yury-Fridlyand requested a review from a team as a code owner May 7, 2024 19:50

Yury-Fridlyand added the testing label May 9, 2024

jonathanl-bq approved these changes May 9, 2024

View reviewed changes

java/client/src/main/java/glide/api/commands/GenericBaseCommands.java Outdated Show resolved Hide resolved

node/src/BaseClient.ts Outdated Show resolved Hide resolved

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

Address PR comments.

2be8d41

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad…

3f91912

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

aaron-congo reviewed May 10, 2024

View reviewed changes

Yury-Fridlyand and others added 2 commits May 10, 2024 13:26

Apply suggestions from code review

72f7960

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>

Update and fix doc and tests.

7afa3e0

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

aaron-congo reviewed May 10, 2024

View reviewed changes

Yury-Fridlyand commented May 10, 2024

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

Yury-Fridlyand and others added 3 commits May 10, 2024 16:59

Apply suggestions from code review

f4b3b2f

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>

I HATE YOU SPOTLESS

60ab21c

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad…

5aaaf6c

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand commented May 13, 2024

View reviewed changes

node/tests/RedisClusterClient.test.ts Outdated Show resolved Hide resolved

Yury-Fridlyand mentioned this pull request May 13, 2024

Python: Added ZINTERSTORE and ZUNIONSTORE commands #1388

Merged

Update node IT.

755e114

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

aaron-congo approved these changes May 13, 2024

View reviewed changes

acarbonetto approved these changes May 13, 2024

View reviewed changes

Elen-Ghulam approved these changes May 13, 2024

View reviewed changes

Yury-Fridlyand marked this pull request as draft May 13, 2024 23:37

Yury-Fridlyand added 2 commits May 13, 2024 16:39

Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad…

21a8e72

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Update tests.

eb99cfe

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand marked this pull request as ready for review May 13, 2024 23:49

Add version check.

7d11ce6

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand mentioned this pull request May 14, 2024

Python: add BZMPOP command #1412

Merged

shohamazon reviewed May 15, 2024

View reviewed changes

Yury-Fridlyand and others added 4 commits May 15, 2024 21:19

Apply suggestions from code review

8616ea4

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

I HATE YOU SPOTLESS

87f000a

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Merge remote-tracking branch 'upstream/main' into java/inter_yuryf_ad…

57b28cb

…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Update python IT.

0c917d5

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand mentioned this pull request May 16, 2024

Python: add sinter command Bit-Quill/glide-for-redis#285

Merged

acarbonetto merged commit a2171ee into aws:main May 17, 2024
23 checks passed

acarbonetto deleted the java/inter_yuryf_add_crossslot branch May 17, 2024 18:57

Yury-Fridlyand added a commit to Bit-Quill/glide-for-redis that referenced this pull request May 17, 2024

Hotfix for aws#1391 - resolving conflict with aws#1419.

3cee6b1

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand mentioned this pull request May 17, 2024

Node: Hotfix for #1391 - resolving conflict with #1419. #1424

Merged

acarbonetto pushed a commit that referenced this pull request May 17, 2024

Node: Hotfix for #1391 - resolving conflict with #1419. (#1424)

9712df2

Hotfix for #1391 - resolving conflict with #1419. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand mentioned this pull request May 18, 2024

Java/dev tjz lmpop Bit-Quill/glide-for-redis#291

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing doc and tests for multi-key commands #1391

Add missing doc and tests for multi-key commands #1391

Yury-Fridlyand commented May 7, 2024

jonathanl-bq left a comment

Yury-Fridlyand commented May 10, 2024

Yury-Fridlyand commented May 10, 2024

Yury-Fridlyand commented May 13, 2024

shohamazon May 15, 2024

shohamazon May 15, 2024

Yury-Fridlyand May 16, 2024

shohamazon May 16, 2024

	* @apiNote When in cluster mode, <code>destination</code> and all <code>keysOrWeightedKeys</code>
	* @apiNote When in cluster mode, <code>destination</code> and all keys <code>keysOrWeightedKeys</code>

Add missing doc and tests for multi-key commands #1391

Add missing doc and tests for multi-key commands #1391

Conversation

Yury-Fridlyand commented May 7, 2024

jonathanl-bq left a comment

Choose a reason for hiding this comment

Yury-Fridlyand commented May 10, 2024

Yury-Fridlyand commented May 10, 2024

Yury-Fridlyand commented May 13, 2024

shohamazon May 15, 2024

Choose a reason for hiding this comment

shohamazon May 15, 2024

Choose a reason for hiding this comment

Yury-Fridlyand May 16, 2024

Choose a reason for hiding this comment

shohamazon May 16, 2024

Choose a reason for hiding this comment