Java: Add GETBIT command
#1400
Merged
Java: Add GETBIT command
#1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
barshaul,
Yury-Fridlyand,
acarbonetto and
tjzhang-BQ
Yury-Fridlyand
approved these changes
May 10, 2024
jonathanl-bq
approved these changes
May 14, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
May 14, 2024
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 14, 2024
| * assert payload == 1L; // The second bit for string stored at "myKey1" is set to 1. | ||
| * }</pre> | ||
| */ | ||
| CompletableFuture<Long> getbit(String key, long offset); |
There was a problem hiding this comment.
consider something smaller than Long for the return type.
There was a problem hiding this comment.
I thought we only had Long and Double types for all number types. Would introducing Integer/Byte/Short cause any issues?
There was a problem hiding this comment.
lets stick with long until we have a consensus
There was a problem hiding this comment.
As per the discussion offline, we are going to use long. This can be switched in the future if a boolean or byte is preferred.
GumpacG
force-pushed
the
java/integ_guiang_getbit
branch
from
4fdc477
to
2129dda
Compare
shohamazon
approved these changes
May 16, 2024
| * assert payload == 1L; // The second bit for string stored at "myKey1" is set to 1. | ||
| * }</pre> | ||
| */ | ||
| CompletableFuture<Long> getbit(String key, long offset); |
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
May 16, 2024
GumpacG
force-pushed
the
java/integ_guiang_getbit
branch
from
2129dda
to
fc9bb15
Compare
* Added GETBIT command Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Applied spotless Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed duplicate test case Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added comments to tests Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
…s.java Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
…s.java Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
GumpacG
force-pushed
the
java/integ_guiang_getbit
branch
from
466ac62
to
2c46236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Implements
GETBITcommand in the java client.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.