JAVA: Add command GEODIST (#272) #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* JAVA: Add command GEODIST * allowing for overloaded signature to pass command with no metric option * undo changes to examplesApp * removing geoadd from geodist example * converting comments to javadocs, removing explicit array creation & redundant test case --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
tjzhang-BQ
requested review from
acarbonetto,
Yury-Fridlyand,
GumpacG,
aaron-congo and
jonathanl-bq
Yury-Fridlyand
approved these changes
May 10, 2024
aaron-congo
reviewed
May 10, 2024
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
May 13, 2024
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
aaron-congo
approved these changes
May 13, 2024
Elen-Ghulam
approved these changes
May 13, 2024
avifenesh
pushed a commit
that referenced
this pull request
May 14, 2024
* JAVA: Add command GEODIST (#272) * JAVA: Add command GEODIST * allowing for overloaded signature to pass command with no metric option * undo changes to examplesApp * removing geoadd from geodist example * converting comments to javadocs, removing explicit array creation & redundant test case --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com> * fixing comment * addressing review comments * adding clickable link for metric value in javadoc --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA: Add command GEODIST
allowing for overloaded signature to pass command with no metric option
undo changes to examplesApp
removing geoadd from geodist example
converting comments to javadocs, removing explicit array creation & redundant test case
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.