Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jsii/runtime): "maximum call stack size exceeded" in SyncStdio.readLine #1717

Merged
merged 4 commits into from
Jun 11, 2020

Commits on Jun 8, 2020

  1. fix(@jsii/runtime): "maximum call stack size exceeded" in SyncStdio.r…

    …eadLine
    
    When using node `>= 12.17`, `EAGAIN` errors consistently occur when
    trying to read from `stdin` when there is no available data. The retry
    mechanism for this was to recursively call back `SyncStdio.readLine`,
    which could evtnually lead to a "Maximum call stack size exceeded" error
    to occur (possibly hidden from the consumer, and later causing a "Stream
    closed" error).
    
    This changes how the retry mechanism works so it operates in a `while`
    loop instead of making a recursive call, completely avoiding to run into
    the growing stack issue.
    
    Fixes aws/aws-cdk#8288
    Fixes aws/aws-cdk#5187
    RomainMuller committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    599fc52 View commit details
    Browse the repository at this point in the history
  2. adjust comment

    RomainMuller committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    ecd05a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb4216c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    fc5bc91 View commit details
    Browse the repository at this point in the history