Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from lerna to turborepo #3512

Closed
wants to merge 5 commits into from

Conversation

RomainMuller
Copy link
Contributor

Since lerna is unmaintained,
this PR is migrating the aws/jsii repository to turborepo,
and plain yarn workspaces commands (and wsrun) as replacements.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller RomainMuller self-assigned this May 3, 2022
@RomainMuller RomainMuller requested a review from a team May 3, 2022 13:47
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 3, 2022
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Did we decide against switching everything to build out of source?


1. Check out this respository and change directory to its root.
2. Run `yarn install && yarn build` to install lerna, bootstrap the repository
and perform an initial build and test cycle.
2. Run `yarn install && yarn test` to install the necessary dependencies,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why yarn test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test implies build in the turbo pipeline, and it makes sure your environment is healthy (has all requirements, etc...)

},
"test": {
"dependsOn": [
"build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this answers my question for me.

@RomainMuller
Copy link
Contributor Author

Did we decide against switching everything to build out of source?

No, but I'll do that separately, package-by-package.

@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label May 3, 2022
Comment on lines +1 to +2
{
"$schema": "https://turborepo.org/schema.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this could make for a good projen component 😉

@RomainMuller
Copy link
Contributor Author

Closing as lerna is no longer dead as Nrwl has taken over maintaining it.

@RomainMuller RomainMuller deleted the rmuller/migrate-off-lerna branch June 29, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants